Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(all-pages-panel): added all pages panel #109

Merged
merged 5 commits into from
Sep 29, 2023
Merged

feat(all-pages-panel): added all pages panel #109

merged 5 commits into from
Sep 29, 2023

Conversation

catakot
Copy link
Contributor

@catakot catakot commented Sep 26, 2023

No description provided.

@catakot catakot force-pushed the feat/all-pages branch 2 times, most recently from 7dc1930 to be1ec3e Compare September 26, 2023 15:39
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

DarkGenius
DarkGenius reviewed Sep 27, 2023
View reviewed changes
src/components/AllPagesPanel/AllPagesPanel.tsx Outdated
const menuItemsRef = useRef(menuItems);
menuItemsRef.current = menuItems;

const [isEditMode, setIsActive] = useState(false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setIsEditMode - more preferable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

DarkGenius
DarkGenius reviewed Sep 27, 2023
View reviewed changes
src/components/AllPagesPanel/i18n/index.ts Outdated
import en from './en.json';
import ru from './ru.json';

const COMPONENT = 'MobileHeader';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let fix component name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

DarkGenius
DarkGenius requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@DarkGenius DarkGenius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create button should be at the end of the list

image

@catakot catakot force-pushed the feat/all-pages branch 2 times, most recently from eccc079 to 09333be Compare September 27, 2023 16:00
@Lunory
Copy link
Collaborator

Lunory commented Sep 28, 2023 •
edited
Loading

FIXED

  1. All pages panel doesn’t close by clicking “All pages” menu item
    telegram-cloud-photo-size-2-5235718919879250331-y

  2. When you are opening panel from popup, popup doesn’t close
    telegram-cloud-photo-size-2-5235718919879250230-y

DarkGenius
DarkGenius reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@DarkGenius DarkGenius left a comment •
edited by Lunory
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lunory@ up: FIXED

The element "All pages" should be highlighted while the panel is open

image

@catakot catakot merged commit 1ed3ba3 into main Sep 29, 2023
3 checks passed
@catakot catakot deleted the feat/all-pages branch September 29, 2023 07:28
@gravity-ui-bot gravity-ui-bot mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lunory Lunory Lunory approved these changes

@DarkGenius DarkGenius DarkGenius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catakot @gravity-ui-bot @Lunory @DarkGenius